Hi,
On 02-07-18 09:07, Benjamin Tissoires wrote:
On Sun, Jul 1, 2018 at 2:26 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi,
On 18-06-18 12:09, Hans de Goede wrote:
Hi,
On 01-06-18 15:05, Hans de Goede wrote:
Hi Jiri,
Here is a resend of my patch series on top of Alexandrov's new hid-elan
driver to make the driver more generic (query params instead of
hardcoding
them).
This has been tested on a HP x2 10-n000nd's touchpad.
I guess you're waiting for feedback from Alexandrov, when I started
working
on this series I tried to coordinate with him but his email was bouncing.
It now no longer bounces, but I'm not sure if the mails going there are
actually being read.
It would be nice to get this into 4.18, so hence this resend.
Gentle ping? what its the status on this?
Another gentle ping, it would be nice to get some feedback on this
and/or get it queued up for 4.19.
Hi Hans,
sorry for the delay in the review. I can review the code, but not the
behavior. Were you able to test (or have someone tested) the
originally supported hardware?
Unfortunately know. I've managed to find a way to get access to a device
which should have the same touchpad now. I will test this after Guadec.
If not, that would block my review to give you a proper ack.
If you tested both devices, you have my rev-by (minus the slight
nitpick in the resolution support patch).
See above. My touchpad is from an older revision of the same
hardware (HP pavilion x2) so I expect the original one to work fine
too.
To check that the resolution, etc. queries work on other Elan
hardware too I've ran some tests on a Toshiba Click Mini L9W
which has a keyboard/touchpad combo i2c-hid device.
The query code worked here in one go. I did need to change
the input report parsing code a bit, the finger info is the
same, but the header contains 1 less byte and all fingers
are in a single larger packet.
With the new code to parse the i2c format input report, the
touchpad on the Toshiba Click Mini L9W works fine in native
mode.
I will send out a v2, also addressing your other remark,
with the Toshiba Click Mini L9W supports added.
Note there is some small duplication with
drivers/input/mouse/elan_i2c*.c here, but that driver cannot be
used since it does not support the keyboard part. TBH I think
that where possible all devices using drivers/input/mouse/elan_i2c*.c
should be moved over to using a proper HID driver instead of
this custom driver.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
