Hi there,
this is a humble review request for these patch submissions
which still are open:
[PATCH v3] HID: hid-bigbenff: driver for BigBen Interactive, PS3OFMINIPAD gamepad
Message-ID: <196c9828-7d2e-de60-b984-9bb3bd80513a@xxxxxxxx>
The issues mentioned in the review of v2 have been resolved,
but you made two comments where I asked for feedback in
<7a8dac82-a935-a4d6-9c6a-9559dc36f35b@xxxxxxxx> that haven't been
responded to yet.
[PATCH 0/5] HID: hid-sony.c: Use devm_ api to simplify Sony game device driver
Message-ID: <76bacb70-f61e-6b00-233b-92c43aff1fca@xxxxxxxx>
The code has been tested by Roderick's team at Sony - see
<CAEc3jaCfpt1mCimsL2jkfMnLhLenuZAabJqiJRSsAhtKi08zQw@xxxxxxxxxxxxxx>
- and they appear to be happy with the change.
[PATCH v2] HID: hid-sony: Brighter RGB values and add 8th color.
Message-ID: <d379c448-e6b2-f858-bffa-5c3256c8030a@xxxxxxxx>
Roderick is on holiday now, but v2 fixes the maximum brightness
that he commented on in
<CAEc3jaBvQCYBm6PEPexE_fRn619uRZBdDi6rKie1RagjDU7sww@xxxxxxxxxxxxxx>
and I hope that it's now ready to use.
[PATCH 0/1] HID: hid-betopff.c: Use devm_kzalloc, move _init() code into _probe().
Message-ID: <b992e649-f5f4-06c0-09a4-876c1b8a11ef@xxxxxxxx>
There has been no response from Huang, the driver's original
author, but he doesn't seem to contribute to Linux mailing
lists, anyway. There have been no comments from the
linux-input mailing list, also.
The patch is just adding the use devm_ and a _small_ code
reshuffle to fix an error handling issue that the original
code forgot to deal with.
Thanks a lot,
Hanno
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
