Thanks for the patch, my comments below.
On Sun, Jun 17, 2018 at 5:03 PM youling257 <youling257@xxxxxxxxx> wrote:
>
> Add touchscreen info for the ONDA V891W Dual OS
It would be nice to end sentences with period.
>
> Signed-off-by: youling257 <youling257@xxxxxxxxx>
There is still couple of things that prevents me to apply:
- please use your real name in SoB
- you forget to add Hans' tag
> ---
> drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 6284946cb0d1..2ad9327c8c0f 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -221,6 +221,24 @@ static const struct ts_dmi_data onda_v891w_v1_data = {
> .properties = onda_v891w_v1_props,
> };
>
> +static const struct property_entry onda_v891w_v3_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-min-x", 35),
> + PROPERTY_ENTRY_U32("touchscreen-min-y", 15),
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1625),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1135),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_STRING("firmware-name",
> + "gsl3676-onda-v891w-v3.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data onda_v891w_v3_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_v891w_v3_props,
> +};
> +
> static const struct property_entry pipo_w2s_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1660),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 880),
> @@ -481,6 +499,15 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"),
> },
> },
> + {
> + /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */
> + .driver_data = (void *)&onda_v891w_v3_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
> + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"),
> + },
> + },
> {
> /* Pipo W2S */
> .driver_data = (void *)&pipo_w2s_data,
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
