Hi Benjamin, thanks again for the review. >> Roderick, you were right that the buttons were mapped wrongly, so >> a mapping is added as requested. The descriptor fixup is still >> needed, as the original descriptor didn't map the analog triggers >> at all. I kept the analog axis remap in the fixup. Also, the >> fixup cleans up the output report to avoid the original >> descriptor's undefined Usage values. > > I am not a big fan of having both a rdesc fixup and input_mapping. > Can't you also fix the button mapping with the fixup? > If it's too hard, the answer 'no' is fine too. The rationale behind it was this: The device sends the analog left/right trigger data in its raw hid data stream, but the original descriptor threw those away and didn't map these incoming data to any axis. For some games, analog triggers are a desirable feature, so a fixup seemed warranted. Thanks for the hint regarding the buttons. I will try to map them in the fixup, too. > we might want to have this failing harder if the report descriptor > doesn't match. Okay, do you have an example for that? > Unless the device is complete garbage with hid-generic, you can just > remove this hunk. Sorry, I do not understand. Why is it not necessary to add that line to hid_have_special_driver? Thanks, Hanno -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
