On Thu, May 31, 2018 at 10:23 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
> On 31-05-18 00:01, Dmitry Torokhov wrote:
>>
>> On Tue, May 22, 2018 at 12:54 PM, Julian Sax <jsbc@xxxxxx> wrote:
>>>
>>> A particular touchpad (SIPODEV SP1064) refuses to supply the HID
>>> descriptors. This patch provides the framework for overriding these
>>> descriptors based on DMI data. It also includes the descriptors for
>>> said touchpad, as well as the DMI data for the 4 laptops known to
>>> use this device.
>>
>>
>> I would love if we did not have to build these quirks into kernel.
>> Given that majority of HID devices are compiled as modules, can we try
>> using request_firmware("<vid>-<pid>.descr") and try to load descriptor
>> overrides from disk before during device initialization?
>
>
> That is an interesting idea and might be worth-while implementing,
> but not to fix these touchpads / replace this patch.
>
> The vid-pid itself comes from the i2c-hid descriptor (which is a HID
> over i2c specific descriptor) and these devices do not report that
> either, they talk HID (over i2c) but seem to rely on a Windows
> filter driver to inject both the i2c-hid descriptor and the actual
> HID descriptors.
>
> We could modify Julian's patch to only provide a i2c-hid descriptor
> override based on DMI strings, but I'm afraid that the hid/pid on
> these cheap Chinese devices are not going to be unique. Actually
> a quick duckduckgo for 0911:5288 finds that the Jumper EZBook 3 PRO,
> which uses a clearly different touchpad (judging from pictures),
> now we could make up our own vid:pid for these touchpads, but that
> feels wrong.
>
> I know this patch is not pretty, but it fixes the touchpad on a
> number of (somewhat popular) budget notebooks, so I think we should
> move forward with this patch.
>
> I've given the patch a good look and it is:
>
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
FWIW, Hans just pinged me again regarding this. Given that it is
sitting on the list for 2 weeks now and that it is not pretty but
fixes issues users are seeing, I am giving my:
Acked-By: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
I would also love to move this in out of the tree firmwares, but
currently -ETIME from me.
Cheers,
Benjamin
>
> Regards,
>
> Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
