On Thu, May 31, 2018 at 06:53:55PM -0400, Ethan Lee wrote: > Just gave this a shot and can confirm that the device is still recognized > when I load the module. I mostly had both lines Just In Case(TM), but I > dunno if there's something important to the other array, so I'll let Bastien > take the wheel from here... let me know if there's anything else I should > test. OK, great, I'll drop the "GDIX1002:00" bit and apply. > > -Ethan > > On 05/31/2018 03:16 PM, Dmitry Torokhov wrote: > > On Wed, May 30, 2018 at 10:19:46AM +0200, Bastien Nocera wrote: > > > On Tue, 2018-05-29 at 15:44 -0700, Dmitry Torokhov wrote: > > > > On Tue, May 29, 2018 at 11:48 AM, <flibitijibibo@xxxxxxxxx> wrote: > > > > > From: Ethan Lee <flibitijibibo@xxxxxxxxx> > > > > > > > > > > GPD Win 2 Website: http://www.gpd.hk/gpdwin2.asp > > > > > > > > > > Tested on a unit from the first production run sent to Indiegogo > > > > > backers > > > > > > > > > > Signed-off-by: Ethan Lee <flibitijibibo@xxxxxxxxx> > > > > > --- > > > > > drivers/input/touchscreen/goodix.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/input/touchscreen/goodix.c > > > > > b/drivers/input/touchscreen/goodix.c > > > > > index 9736c83dd418..6a4ffe800194 100644 > > > > > --- a/drivers/input/touchscreen/goodix.c > > > > > +++ b/drivers/input/touchscreen/goodix.c > > > > > @@ -926,6 +926,7 @@ static SIMPLE_DEV_PM_OPS(goodix_pm_ops, > > > > > goodix_suspend, goodix_resume); > > > > > > > > > > static const struct i2c_device_id goodix_ts_id[] = { > > > > > { "GDIX1001:00", 0 }, > > > > > + { "GDIX1002:00", 0 }, > > > > Do we really need this? And actually the first one as well? > > > It was in the original driver submission, which isn't that old. I don't > > > have a way to test this right now though. > > I am pretty sure we changed the way we generate modaliases for I2C > > devices (from ACPI/OF) since then. > > > > Ethan, can you please try building the driver without the new entry in > > goodix_ts_id, make it a module and make sure it gets autoloaded for > > you. > > > > Thanks. > > > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
