Re: [PATCH v2] xpad: Add GPD Win 2 Controller GUID

[Ethan Lee <flibitijibibo@xxxxxxxxx>]

My mistake! That's a carryover from SDL's terminology, I'll go ahead and 
fix that... will CC stable in v3!

Bastien: Off-topic, but do you think I should CC stable for the goodix 
patch as well?

-Ethan

On 05/30/2018 08:25 PM, Cameron Gutman wrote:
> On 05/29/2018 11:48 AM, flibitijibibo@xxxxxxxxx wrote:
> > From: Ethan Lee <flibitijibibo@xxxxxxxxx>
> >
> > GPD Win 2 Website: http://www.gpd.hk/gpdwin2.asp
> >
> > Tested on a unit from the first production run sent to Indiegogo backers
> Small nit regarding the subject: It's not a GUID.
>
> Other than that, I would also suggest:
>
> Cc: stable@xxxxxxxxxxxxxxx
>
> > Signed-off-by: Ethan Lee <flibitijibibo@xxxxxxxxx>
> > ---
> >   drivers/input/joystick/xpad.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> > index 06e9650b3b30..a89b81b35932 100644
> > --- a/drivers/input/joystick/xpad.c
> > +++ b/drivers/input/joystick/xpad.c
> > @@ -123,6 +123,7 @@ static const struct xpad_device {
> >   	u8 mapping;
> >   	u8 xtype;
> >   } xpad_device[] = {
> > +	{ 0x0079, 0x18d4, "GPD Win 2 Controller", 0, XTYPE_XBOX360 },
> >   	{ 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> >   	{ 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> >   	{ 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX },
> > @@ -409,6 +410,7 @@ static const signed short xpad_abs_triggers[] = {
> >   
> >   static const struct usb_device_id xpad_table[] = {
> >   	{ USB_INTERFACE_INFO('X', 'B', 0) },	/* X-Box USB-IF not approved class */
> > +	XPAD_XBOX360_VENDOR(0x0079),		/* GPD Win 2 Controller */
> >   	XPAD_XBOX360_VENDOR(0x044f),		/* Thrustmaster X-Box 360 controllers */
> >   	XPAD_XBOX360_VENDOR(0x045e),		/* Microsoft X-Box 360 controllers */
> >   	XPAD_XBOXONE_VENDOR(0x045e),		/* Microsoft X-Box One controllers */
> Regards,
> Cameron


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html