Hi Nick, On Thu, May 03, 2018 at 10:47:34PM +0100, Nick Dyer wrote: > [v2: output fw rev on probe] I'd rather we did not as we have sysfs if you need to see it. Also: > @@ -490,8 +568,18 @@ static int mtouch_init(struct usbtouch_usb *usbtouch) > input_set_abs_params(usbtouch->input, ABS_Y, 0, 0xffff, 0, 0); > } > > + ret = sysfs_create_group(&usbtouch->interface->dev.kobj, > + &mtouch_attr_group); > + if (ret) > + return ret; ->init() is called from ->reset_resume(), you do not want to create sysfs attributes in init. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
