Re: [PATCH 2/2] HID: i2c-hid: Silently fail probe for CHPN0001 touchscreen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 3 Apr 2018, Hans de Goede wrote:

> The CHPN0001 ACPI device has a _CID of PNP0C50 and even has the _DSM to
> get the HID descriptor address, but it is not a HID device at all.
> 
> It uses its own protocol which is handled by the (still being upstreamed)
> chipone_icn8505 driver. I guess the _CID and the _DSM are the result of
> a copy and paste job when the vendor was building the ACPI tables.
> 
> Before this patch the i2c_hid_driver's probe function will fail with a
> "hid_descr_cmd failed" error.
> 
> This commit makes the i2c_hid_driver's probe function instead silently
> ignored devices with an ACPI id of CHPN0001.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Hans,

as I don't know exactly what is the timeline for chipone_icn8505 
upstreaming, I'd rather ask -- would you prefer these two patches to go 
into 4.17 still, or is queuing for 4.18 ok?

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux