On Wed, 2018-03-14 at 10:23 -0700, Dmitry Torokhov wrote: [...] > > But I think what you're saying that > > these interrupts will always be edge-triggered, not level-triggered - > > is that right? In which case I agree that screaming interrupts won't > > be a problem. > > Yes, level-triggered interrupts are not usable whenever something is > based on GPIOs as while that "something" is active you'd have interrupt > constantly retriggered as soon as you done processing it. > > We explicitly request interrupts as IRQG_TRIGGER_FALLING | > IRQF_TRIGGER_RISING in matrix-keypad driver. This is not enforced in the clustered IRQ case. Would it make sense to combine those with the specified clustered_irq_flags, or to mention this assumption in the struct matrix_keypad_platform_data doc-comment? Ben. -- Ben Hutchings Software Developer, Codethink Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
