Hi Florent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florent-Flament/Logitech-K290-Add-driver-for-the-Logitech-K290-USB-keyboard/20180305-153311 base: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/hid/hid-logitech-k290.c:54:46: sparse: Using plain integer as NULL pointer vim +54 drivers/hid/hid-logitech-k290.c 45 46 static void k290_set_function(struct usb_device *dev, uint16_t function_mode) 47 { 48 int ret; 49 50 ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), 51 K290_SET_FUNCTION_CMD, 52 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, 53 K290_SET_FUNCTION_VAL, > 54 function_mode, 0, 0, USB_CTRL_SET_TIMEOUT); 55 56 if (ret < 0) 57 dev_err(&dev->dev, 58 "Failed to setup K290 function key, error %d\n", ret); 59 } 60 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
