On Sat, 2018-03-03 at 18:08 +0200, Andy Shevchenko wrote: > On Sat, Mar 3, 2018 at 12:04 AM, Florent Flament > <contact@xxxxxxxxxxxxxxxxxx> wrote: > > With the generic HID driver, K290 keyboards' F1 to F12 keys send > > multimedia events by default, and standard keycodes when the > > function > > key is pressed. This driver allows to configure K290 keyboards, so > > that F1 to F12 have a standard behavior and send multimedia events > > when the function key is pressed. The keyboard mode is set through > > the > > fn_mode module parameter: when set to 1 (default setting) the > > keyboard > > behaves as with the generic HID driver, when set to 0 the keyboard > > is > > configured to work as standard keyboards. > > SPDX ID? > > > +/* > > + * HID driver for Logitech K290 keyboard > > + * > > + * Copyright (c) 2018 Florent Flament > > + * > > + * This drivers allows to configure the K290 keyboard's function > > key > > + * behaviour (whether function mode is activated or not by > > default). > > + * > > + * Logitech custom commands taken from Marcus Ilgner k290-fnkeyctl > > + * (https://github.com/milgner/k290-fnkeyctl): > > + * K290_SET_FUNCTION_CMD > > + * K290_SET_FUNCTION_VAL > > + * K290_SET_FUNCTION_OFF > > + * K290_SET_FUNCTION_ON > > + * > > + * Based on hid-accutouch.c and hid-elo.c > > + * > > + * This driver is licensed under the terms of GPLv2. > > ...instead of this. Fine, I'll replace this with the appropriate SPDX ID. > > > + */ > > + > > +#include <linux/device.h> > > +#include <linux/hid.h> > > +#include <linux/module.h> > > +#include <linux/moduleparam.h> > > +#include <linux/mod_devicetable.h> > > Do you need these both? I suppose module.h effectively provides them. Indeed, module.h is enough. The 2 following includes are not necessary. Fixing this. > > > +#include <linux/stat.h> > > +#include <linux/types.h> > > +#include <linux/usb.h> > > Regards, Florent -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
