On Wednesday, 28 February 2018 17:26:53 CET Arkadiusz Hiler wrote: > On Fri, Feb 23, 2018 at 11:28:10PM +0200, Arkadiusz Hiler wrote: > > This reverts commit 48282969826b3d3c76e908182f69724d86d995fe which > > caused the following issues: > > > > 1. On T460p with BIOS version 2.22 touchpad and trackpoint stop working > > after suspend-resume cycle. Due to strange state of the device another > > suspend is impossible. > > > > The following dmesg errors can be observed: > > thinkpad_acpi: EC reports that Thermal Table has changed > > rmi4_smbus 7-002c: failed to get SMBus version number! > > rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current > > IRQ mask. rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16. > > rmi4_f01 rmi4-00.fn01: Resume failed with code -16. > > rmi4_physical rmi4-00: Failed to suspend functions: -16 > > rmi4_smbus 7-002c: Failed to resume device: -16 > > PM: resume devices took 0.640 seconds > > rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03 TX > > register (-16). rmi4_physical rmi4-00: rmi_driver_clear_irq_bits: Failed > > to change enabled interrupts! rmi4_physical rmi4-00: > > rmi_driver_set_irq_bits: Failed to change enabled interrupts! psmouse: > > probe of serio3 failed with error -1 > > > > 2. On another T460p with BIOS version 2.15 two finger scrolling gesture > > on the touchpad stops working after suspend-resume cycle (about 75% > > reproducibility, when it still works, the scrolling gesture becomes > > laggy). Nothing suspicious appears in the dmesg. > > > > Cc: Zhenjie Wang <zhenjie.wang@xxxxxxxxxxx> > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx> > > Tested-by: Martin Peres <martin.peres@xxxxxxxxxxxxxxx> > > Tested-by: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx> > > Hey, > > I just found exact same revert by Richard Schütz sent earlier to the > linux-input list (<20180219193523.6287-1-rschuetz@xxxxxxxxxxxxxx>). > > There's also this conversation https://lkml.org/lkml/2018/2/13/68 > > I would appreciate if the revert would be applied soon. Constant > reapplying of the patch and recompiling the kernel just to have suspend > and pointing devices working on the T460p is pretty laborious :-) FWIW, I also saw similar behavior here with kernel 4.14.x and my Lenovo T440s. It's not happening in a reproducible way for me however. Sometimes after resume the pointer doesn't move (and then prevents further suspends) and sometimes multi-touch gestures don't work (two finger click, etc). Both cases happen rather rarely, but they do happen. Grs, Heinz
Attachment:
signature.asc
Description: This is a digitally signed message part.
