On 02/06/2018 10:01 PM, Florian Echtler wrote:
> The SUR40 can recognize specific printed patterns directly in hardware;
> this information (i.e. the pattern id) is present but currently unused
> in the blob structure.
>
> Signed-off-by: Florian Echtler <floe@xxxxxxxxxxxxxx>
> ---
> drivers/input/touchscreen/sur40.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index f16f835..8375b06 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -81,7 +81,10 @@ struct sur40_blob {
>
> __le32 area; /* size in pixels/pressure (?) */
>
> - u8 padding[32];
> + u8 padding[24];
> +
> + __le32 tag_id; /* valid when type == 0x04 (SUR40_TAG) */
> + __le32 unknown;
>
> } __packed;
>
>
Usually new fields are added before the padding, not after.
Unless there is a good reason for this I'd change this.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
