From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Sat, 27 Jan 2018 12:56:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/input/keyboard/max7359_keypad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c index cd44d22d8770..ba6a670a769e 100644 --- a/drivers/input/keyboard/max7359_keypad.c +++ b/drivers/input/keyboard/max7359_keypad.c @@ -184,10 +184,8 @@ static int max7359_probe(struct i2c_client *client, keypad = devm_kzalloc(&client->dev, sizeof(struct max7359_keypad), GFP_KERNEL); - if (!keypad) { - dev_err(&client->dev, "failed to allocate memory\n"); + if (!keypad) return -ENOMEM; - } input_dev = devm_input_allocate_device(&client->dev); if (!input_dev) { -- 2.16.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html