Re: [PATCH v3 3/3] Input: goodix - use generic touchscreen_properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On 27 Jan 2018, at 00:57, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> 
>> On Fri, Jan 26, 2018 at 3:48 PM, Bastien Nocera <hadess@xxxxxxxxxx> wrote:
>>> On Fri, 2018-01-26 at 11:19 -0800, Dmitry Torokhov wrote:
>>> Can you please try the version below (note that I sqashed all your 3
>>> patches in one as, as I mentioed, I do not see why they need to be
>>> split
>>> in the first place).
>> 
>> It was easier to read, and backport. Patch 1 and 2 at least are easily
>> backportable, and "easy" fixes on top of the existing code. Breakages
>> would be easier to spot with the 3 separate fixes, and that's how I'd
>> prefer it if it's not too much bother.
> 
> There is nothing to read if you drop the patch 2, as it is something
> that was done and immediately deleted.

It’s easier to backport and understand. Fine if you don’t want it. I’d rather it was still there.

> 
> Thanks.
> 
> -- 
> Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux