On 01/17/2018 11:45 AM, Marcus Folkesson wrote: > Hi Randy! > > On Wed, Jan 17, 2018 at 11:13:43AM -0800, Randy Dunlap wrote: >> On 01/17/2018 11:07 AM, Marcus Folkesson wrote: >>> This driver let you plug in your RC controller to the adapter and >>> use it as input device in various RC simulators. >>> >>> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx> >>> --- >> >>> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig >>> index f3c2f6ea8b44..18ab6dafff41 100644 >>> --- a/drivers/input/joystick/Kconfig >>> +++ b/drivers/input/joystick/Kconfig >>> @@ -351,4 +351,13 @@ config JOYSTICK_PSXPAD_SPI_FF >>> >>> To drive rumble motor a dedicated power supply is required. >>> >>> +config JOYSTICK_PXRC >>> + tristate "PhoenixRC Flight Controller Adapter" >>> + depends on USB_ARCH_HAS_HCD >>> + select USB >> >> Drop the (first) depends and change "select USB" to "depends on USB". >> >> Argh, there are lots of input/ drivers that do that. That's bad/wrong. >> A driver should not select (enable) an entire subsystem. If the user had >> the subsystem disabled, it should stay that way. >> >> Dmitry, you can expect some patches... >> > > Hah, of course it should be "depends on" :-) > Other drivers fooled me... > > Should I fix the other drivers too when I'm on it, or do you? Either way. If you are up for it, please go ahead. thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
