Re: [PATCH 2/2] HID: asus: Fix special function keys on T200TA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 5, 2018 at 12:09 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Just like on the T100TA the T200TA HID descriptors for the 0xff32
> Asus vendor usage page need a small fixup. But on the T200TA the HID
> descriptors are larger because they have descrriptors for one more
> (unused) HID report appended.
>
> Extend the T100TA descriptor fixup to also check for the T200TA's
> descriptors size.

Sigh, both are:
Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Cheers,
Benjamin

>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/hid/hid-asus.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 07525bc99b6a..88b9703318e4 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -715,9 +715,10 @@ static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
>                 hid_info(hdev, "Fixing up Asus notebook report descriptor\n");
>                 rdesc[55] = 0xdd;
>         }
> -       /* For the T100TA keyboard dock */
> +       /* For the T100TA/T200TA keyboard dock */
>         if (drvdata->quirks & QUIRK_T100_KEYBOARD &&
> -                *rsize == 76 && rdesc[73] == 0x81 && rdesc[74] == 0x01) {
> +                (*rsize == 76 || *rsize == 101) &&
> +                rdesc[73] == 0x81 && rdesc[74] == 0x01) {
>                 hid_info(hdev, "Fixing up Asus T100 keyb report descriptor\n");
>                 rdesc[74] &= ~HID_MAIN_ITEM_CONSTANT;
>         }
> --
> 2.14.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux