On Mon, Dec 4, 2017 at 5:44 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote: >> struct timeval is not y2038 safe. >> All references to timeval will be deleted from the >> kernel to make it y2038 safe. >> Replace its uses by y2038 safe struct timespec64. >> >> The timestamps changed here only keep track of delta >> times. These timestamps are also internal to kernel. >> Hence, monotonic times are sufficient here. >> The unit of the delta times is also changed in certain >> cases to nanoseconds rather than microseconds. This is >> in line with timespec64 which keeps time in nanoseconds. >> >> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx> >> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > > Hi Deepa, > > I forgot you also had these on your backlog. I submitted a different > set of patches > two weeks ago for the two HP drivers, originally by Pingbo Wen, based on a > different approach. > > That version simplified the code in question a bit more by using jiffies, > while your version is a little safer since it changes less. Both versions > should be fine though, it's up to Dmitry which one he wants to pick up. Dmitry, please let me know if you would like this version. If not, I can drop the patch when I post an update. -Deepa -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
