[input:next 2001/2002] drivers/input/touchscreen/hideep.c:472:14: note: in expansion of macro 'min'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
head:   8214d762fa9a6e6a5a1d97e1d6c54b2a3468eaec
commit: d1d2c98c3adc779fb6f31ac4fcfdbd2b0efb6be8 [2001/2002] Input: add support for HiDeep touchscreen
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        git checkout d1d2c98c3adc779fb6f31ac4fcfdbd2b0efb6be8
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/list.h:9:0,
                    from include/linux/module.h:9,
                    from drivers/input/touchscreen/hideep.c:9:
   drivers/input/touchscreen/hideep.c: In function 'hideep_program_nvm':
   include/linux/kernel.h:791:16: warning: comparison of distinct pointer types lacks a cast
     (void) (&min1 == &min2);   \
                   ^
   include/linux/kernel.h:800:2: note: in expansion of macro '__min'
     __min(typeof(x), typeof(y),   \
     ^~~~~
>> drivers/input/touchscreen/hideep.c:472:14: note: in expansion of macro 'min'
      xfer_len = min(ucode_len, HIDEEP_NVM_PAGE_SIZE);
                 ^~~
   drivers/input/touchscreen/hideep.c: In function 'hideep_verify_nvm':
   include/linux/kernel.h:791:16: warning: comparison of distinct pointer types lacks a cast
     (void) (&min1 == &min2);   \
                   ^
   include/linux/kernel.h:800:2: note: in expansion of macro '__min'
     __min(typeof(x), typeof(y),   \
     ^~~~~
   drivers/input/touchscreen/hideep.c:518:14: note: in expansion of macro 'min'
      xfer_len = min(ucode_len, HIDEEP_NVM_PAGE_SIZE);
                 ^~~

vim +/min +472 drivers/input/touchscreen/hideep.c

   458	
   459	static int hideep_program_nvm(struct hideep_ts *ts,
   460				      const __be32 *ucode, size_t ucode_len)
   461	{
   462		struct pgm_packet *packet_r = (void *)ts->xfer_buf;
   463		__be32 *current_ucode = packet_r->payload;
   464		size_t xfer_len;
   465		size_t xfer_count;
   466		u32 addr = 0;
   467		int error;
   468	
   469		hideep_nvm_unlock(ts);
   470	
   471		while (ucode_len > 0) {
 > 472			xfer_len = min(ucode_len, HIDEEP_NVM_PAGE_SIZE);
   473			xfer_count = xfer_len / sizeof(*ucode);
   474	
   475			error = hideep_pgm_r_mem(ts, 0x00000000 + addr,
   476						 current_ucode, xfer_count);
   477			if (error) {
   478				dev_err(&ts->client->dev,
   479					"%s: failed to read page at offset %#08x: %d\n",
   480					__func__, addr, error);
   481				return error;
   482			}
   483	
   484			/* See if the page needs updating */
   485			if (memcmp(ucode, current_ucode, xfer_len)) {
   486				error = hideep_program_page(ts, addr,
   487							    ucode, xfer_count);
   488				if (error) {
   489					dev_err(&ts->client->dev,
   490						"%s: iwrite failure @%#08x: %d\n",
   491						__func__, addr, error);
   492					return error;
   493				}
   494	
   495				usleep_range(1000, 1100);
   496			}
   497	
   498			ucode += xfer_count;
   499			addr += xfer_len;
   500			ucode_len -= xfer_len;
   501		}
   502	
   503		return 0;
   504	}
   505	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux