Re: [PATCH v3 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 5, 2017 at 6:09 PM, Yiannis Marangos
<yiannis.marangos@xxxxxxxxx> wrote:
> Some synaptics devices such as LEN0073 use SMBUS version 3.
>
> Signed-off-by: Yiannis Marangos <yiannis.marangos@xxxxxxxxx>
> ---

In the same way v2 was:
Acked-by: Benjamin Tissoires <benjamion.tissoires@xxxxxxxxxx>

This also applies to 2/2.

Yiannis, please next time keep the various acked-by, rev-by already
provided by reviewers, this is less work for the maintainer to gather
them if they are already there.

Cheers,
Benjamin

>  drivers/input/rmi4/rmi_smbus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
> index 225025a0940c..b6ccf39c6a7b 100644
> --- a/drivers/input/rmi4/rmi_smbus.c
> +++ b/drivers/input/rmi4/rmi_smbus.c
> @@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
>         rmi_smb->xport.dev = &client->dev;
>         rmi_smb->xport.pdata = *pdata;
>         rmi_smb->xport.pdata.irq = client->irq;
> -       rmi_smb->xport.proto_name = "smb2";
> +       rmi_smb->xport.proto_name = "smb";
>         rmi_smb->xport.ops = &rmi_smb_ops;
>
>         smbus_version = rmi_smb_get_version(rmi_smb);
> @@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
>         rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
>                 smbus_version);
>
> -       if (smbus_version != 2) {
> +       if (smbus_version != 2 && smbus_version != 3) {
>                 dev_err(&client->dev, "Unrecognized SMB version %d\n",
>                                 smbus_version);
>                 return -ENODEV;
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux