On Mon, Oct 02, 2017 at 03:18:52PM -0700, Guenter Roeck wrote: > On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > The array rmi_f54_report_type_names is local to the source and does > > not need to be in global scope, so make it static. Also make the array > > const char * const > > > > Cleans up sparse warning: > > symbol 'rmi_f54_report_type_names' was not declared. Should it be static? > > > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> Applied, thank you. > > > --- > > drivers/input/rmi4/rmi_f54.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c > > index f5206e2c767e..70f6310f1d15 100644 > > --- a/drivers/input/rmi4/rmi_f54.c > > +++ b/drivers/input/rmi4/rmi_f54.c > > @@ -73,7 +73,7 @@ enum rmi_f54_report_type { > > F54_MAX_REPORT_TYPE, > > }; > > > > -const char *rmi_f54_report_type_names[] = { > > +static const char * const rmi_f54_report_type_names[] = { > > [F54_REPORT_NONE] = "Unknown", > > [F54_8BIT_IMAGE] = "Normalized 8-Bit Image", > > [F54_16BIT_IMAGE] = "Normalized 16-Bit Image", > > -- > > 2.14.1 > > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html