On Mon, Sep 18, 2017 at 04:43:57PM +0100, Steven Joruk wrote:
> The code is fine, but make it clear to the compiler.
>
> drivers/input/misc/adxl34x.c:134:35: warning: ‘<<’ in boolean context
>
> Signed-off-by: Steven Joruk <steven@xxxxxxxxx>
> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
> index 2b2d02f408bb..e0caaa0de454 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -796,7 +796,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
>
> if (pdata->watermark) {
> ac->int_mask |= WATERMARK;
> - if (!FIFO_MODE(pdata->fifo_mode))
> + if (FIFO_MODE(pdata->fifo_mode) == 0)
This has been NAKed before:
https://www.spinics.net/lists/linux-ide/msg54485.html
I'll pick up the V2 from Arnd that is better.
> ac->pdata.fifo_mode |= FIFO_STREAM;
> } else {
> ac->int_mask |= DATA_READY;
> --
> 2.14.1
>
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
