Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On Mon, Aug 28, 2017 at 6:50 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote:
>> mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only
>> when MMU is selected.
>>
>> To avoid linking errors, make INPUT_M68K_BEEP depend on MMU.
>
> Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU

Sounds OK to me. Greg?

> dependency seems to be artificial.

That's indeed artificial, it's really a platform dependency.
But currently these platforms (Amiga and Atari) do not support mmu-less
operation (yet).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux