Re: [PATCH v4 2/2] HID: wacom: Improve generic name generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 26 Jul 2017, Benjamin Tissoires wrote:

> On Jul 24 2017 or thereabouts, Jason Gerecke wrote:
> > The 'wacom_update_name' function is responsible for producing names for
> > the input device nodes based on the hardware device name. Commit f2209d4
> > added the ability to strip off prefixes like "Wacom Co.,Ltd." where the
> > prefix was immediately (and redundantly) followed by "Wacom". The
> > 2nd-generation Intuos Pro 2 has such a prefix, but with a small error
> > (the period and comma are swapped) that prevents the existing code from
> > matching it. We're loath to extend the number of cases out endlessly and
> > so instead try to be smarter about name generation.
> > 
> > We observe that the cause of the redundant prefixes is HID combining the
> > manufacturer and product strings of USB devices together. By using the
> > original product name (with "Wacom" prefixed, if it does not already
> > exist in the string) we can bypass the gyrations to find and remove
> > redundant prefixes. Other devices either don't have a manufacturer string
> > that needs to be removed (Bluetooth, uhid) or should have their name
> > generated from scratch (I2C).
> > 
> > Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> > ---
> 
> For the series:
> Acked-By: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Now in for-4.14/wacom. Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux