Hi Maxime, On 18/07/2017 09:57, Maxime Ripard wrote: > On Tue, Jul 18, 2017 at 09:36:04AM +0200, Quentin Schulz wrote: >>>> + >>>> + error = sysfs_create_group(&pdev->dev.kobj, >>>> + axp20x_pek->attribute_group); >>> >>> Wouldn't it make more sense to just store the startup_time structure >>> in the axp20x_pek structure, rather than duplicating all this? >>> >> >> I don't know. Basically, you would need to recreate manually all the >> structures in the probe function, but why not. > > Why? > > You have access to axp20x_pek in the readout function. You can just > use the table stored in the structure here, and just ignore any > argument you might have. > All I'm saying is that: struct axp20x_time is referenced in struct axp20x_pek_ext_attr which in turn is referenced in struct dev_ext_attribute which is referenced in struct attribute which is reference in const struct attribute_group which is finally used to add/remove a sysfs group programmatically. The earlier in the chain you decide to stop duplicating code, the most structures you have to programmatically create. That was my point. Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: OpenPGP digital signature
