Hi Lee, On 18/07/2017 09:19, Lee Jones wrote: > On Mon, 17 Jul 2017, Quentin Schulz wrote: > >> According to their datasheets, the AXP221, AXP223, AXP288, AXP803, >> AXP809 and AXP813 PEK have different values for startup time bits from >> the AXP20X, let's use the platform device id with the correct values. >> >> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/mfd/axp20x.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Patch is find, but are these names reference from platform data > anywhere i.e. are we going to break anything by applying it? > I don't really understand what you're asking. We need the first patch of this patch series to be applied before the second patch or axp20x-pek driver wouldn't be probed anymore. There is no Device Tree declaring axp20x-pek and there is no support for Device Tree probing in the driver. I don't see how I could break anything with these patches. Could you explain with an abstract example, please? I might not break anything here but it's better to know now what I could have broken in another situation/with another patch series so I won't make that mistake in the future. Oh, but this patch series would change the name of the directory exposed in sysfs (/sys/bus/platform/devices/axp221-pek/*). Is that what you were afraid of? Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
