Re: [PATCH 0/2] HID: i2c-hid: Do not register i2c_hid_driver on devices with a CHPN0001 touchscreen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 27 2017 or thereabouts, Jiri Kosina wrote:
> On Sun, 18 Jun 2017, Hans de Goede wrote:
> 
> > Hi Jiri, Benjamin,
> > 
> > As discussed with myself in the linux-input thread about adding
> > icn8505 (ACPI HID CHPN0001) devices to the icn8313 driver:
> > https://www.spinics.net/lists/linux-input/msg51916.html
> > 
> > Unfortunately the ACPI node for this non HID compatible device has an
> > ACPI CID (compatility ID) of PNP0C50 causing the i2c-hid driver to bind,
> > which leads to the touchscreen not working (see the second patch
> > commit message for details).
> > 
> > Although these 2 patches are not really pretty I believe they are the
> > best way to fix this.
> > 
> > Note that even if I do add firmware upload support to the icn8318 driver,
> > we still have the issue left of i2c-hid doing a
> > dev_err(dev, "hid_descr_cmd failed") which is also undesirable.
> > 
> > A normal system bootup should have no output for "dmesg --level=err",
> > this is esp. important for the flickerfree boot experience both Fedora
> > and Ubuntu have been working towards. Any _err kernel messages will
> > cause the splash screen to drop back to text-mode breaking the
> > flickerfree experience. So to silence that error we would need to
> > blacklist the CHPN0001 ACPI HID somewhere in the i2c-hid driver
> > anyways.
> 
> Benjamin, as i2c-hid is mainly your playground, would you mind (n)Acking 
> this? :)
> 

Sorry, I should have replied here too.

I still maintain: http://www.spinics.net/lists/linux-input/msg51961.html
So unless we have some new elements, I am NAcking this patch.

Cheers,
Benjamin

> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux