Re: [PATCH v2] Input: goodix: Add support for capacitive home button found on some x86 tablets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-06-20 at 21:08 +1000, Sergei A. Trusov wrote:
> On some x86 tablets with a goodix touchscreen the windows logo on the

"Goodix" and "Windows", comma after "touchscreen".

> front is a capacitive home button. Touching this button results in a
> touch
> with bit 4 of the first byte set, while normally only the lower 4
> bits

Add "(0-3)" after "bits".

> are used to indicate the number of touches.
> 
> Detect this and report a KEY_LEFTMETA press when this happens. Note 

You can remove the "Detect this and".

> the
> hardware might support more than one button, the number of a button
> is
> reported by the 'id' byte of coor_data.

"Note that the hardware might support more than one button, in which
case the "id" byte of coor_data would identify the button in question.
This is not implemented as we don't have access to hardware with
multiple buttons."

>  Now we ignore button id.

Remove that last sentence.

> 
> Signed-off-by: Sergei A. Trusov <sergei.a.trusov@xxxxx>

Looks good from me. Sergei, Dmitry, let me know if you want me to re-
send the patch with a fixed up commit message.

Acked-by: Bastien Nocera <hadess@xxxxxxxxxx>

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux