Re: [PATCH] Input: goodix: Add support for capacitive home button found on some x86 tablets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 20-06-17 10:36, Bastien Nocera wrote:
On Mon, 2017-06-19 at 19:51 -0700, Dmitry Torokhov wrote:
General question though, should we not only export and advertise
the
button if it exists on the device?

Yes, this is preferred behavior.

So we'll want a dmi match table for the devices that need this feature,
and only export the button for those.

Note Dmitry said that this is preferred behavior, not something which
we MUST do. And TBH I don't think that using a DMI table is a good idea,
the capacitive home-button is not only found on the HP stream 7 but also
on various cheap tablets, of which there tend to be a lot, so the DMI
table is going to be use. And the cheap tablets often have useful
model strings such as e.g. "Default String" making DMI matching a
nasty problem.

So IMHO it is better to just always report the presence of the
home button, in practice I don't think userspace is going to have
any problems with this.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux