Re: [PATCH] Input: psmouse - reset device during probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Po 5. Jún 2017 22:27 Daniel Drake wrote:
> New Acer laptops (Aspire A315-31 and several others) have an EC which
> expects the PS/2 reset command to happen during boot.
> 
> On Linux, that means that currently the touchpad is unresponsive until
> suspend/resume, when psmouse_reconnect() resets the device.
> 
> We observe that Windows sends a PS/2 reset command during boot.
> Make Linux do the same here, making the touchpad usable on these
> new products.
> 
> Signed-off-by: Daniel Drake <drake@xxxxxxxxxxxx>
> ---
>  drivers/input/mouse/psmouse-base.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/input/mouse/psmouse-base.c
> b/drivers/input/mouse/psmouse-base.c index f73b47b8c578..8f3c903db7b9
> 100644 --- a/drivers/input/mouse/psmouse-base.c
> +++ b/drivers/input/mouse/psmouse-base.c
> @@ -1591,6 +1591,12 @@ static int psmouse_connect(struct serio *serio,
> struct serio_driver *drv)
>  psmouse->resync_time = parent ? 0 : psmouse_resync_time;
>  psmouse->smartscroll = psmouse_smartscroll;
>  
> +	/* Reset the device, even though we would ordinarily expect it to
> +	 * already be in the reset state. This matches Windows behaviour,
> +	 * which some ECs require.
> +	 */
> +	psmouse_reset(psmouse);
> +
>  psmouse_switch_protocol(psmouse, NULL);
>  
>  if (!psmouse->protocol->smbus_companion) {

This patch will slow down enumeration and initalization of *all* PS/2 mouses.

I guess if there are some problematic machines, it could be hooked...

-- 
Pali Rohár
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux