On Wed, 2017-06-07 at 16:28 +0200, Benjamin Tissoires wrote:
> On Jun 07 2017 or thereabouts, Bastien Nocera wrote:
<snip>
> > + hid_err(hdev, "parse failed\n");
>
> This error message is probably too much, just return in case of
> failure,
> we will get an error if something wrong happens.
>
> > + return ret;
> > + }
> > +
> > + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> > + if (ret) {
> > + hid_err(hdev, "hw start failed\n");
>
> Same here.
Both fixed.
> > +static const struct hid_device_id retrode_devices[] = {
> > + { HID_USB_DEVICE(USB_VENDOR_ID_FUTURE_TECHNOLOGY,
> > USB_DEVICE_ID_RETRODE2) },
>
> Aren't you missing the same entry in hid-core.c
> hid_have_special_driver?
I guess I am, fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
