Re: [PATCH 2/2 v3] input: keyboard: Add D-Link DIR-685 touchkeys driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 30, 2017 at 6:40 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Tue, May 30, 2017 at 02:09:18PM +0200, Linus Walleij wrote:
>> +     /*
>> +      * This key appears in the vendor driver, but I have
>> +      * not been able to provoke it.
>> +      */
>> +     tk->codes[6] = KEY_O;
>
> If there is no way to make the device produce this key, should we mark
> is as KEY_RESERVED? KEY_O would not be suitable in any case, we'd need
> to find more suitable keycode for whatever function is has.

OK I'm in on this.

> If it is OK I can make the change locally.

Sure go ahead when applying!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux