On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer in > > > one go. > > > > > > Also use hweight8 to count number of partitions instead of inspecting it > > > bit by bit. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > > --- > > > > Looks good to me: > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Hm, I just realized taht we'd go from upper to lowercase hex digits. I > think it should be OK, but I'd like to hear interested parties (Nick). > > Or we'd need to introduce %pH I guess. As it's debugging output, I'd hazard to guess it doesn't matter. If someone _really_ needs upper-case output in *ph, I'd also suggest adding another qualifier to keep the number of letter prefixes used down. %ph[CDNU]. A pity that %ph[cdnCDN] isn't possible as that's the style used by %pU[blBL] for lower/upper case output. There are < 80 uses of %[\*\d]+ph[CDN], maybe it'd be reasonable to do a treewide sed to lowercase for them. Dunno. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
