On 05/11/2017 03:22 PM, Benjamin Valentin wrote: > On Mon, 8 May 2017 22:18:49 -0700 > Cameron Gutman <aicommander@xxxxxxxxx> wrote: > >> It looks like you dropped a few entries from xpad_table[]. With that >> table, I'd rather just list the VIDs and risk a chance it's wrong and >> doesn't work than not list it and guarantee 100% that it won't work. >> If the interface descriptor doesn't look right to us, we won't touch >> it anyway. > > Well I'm not so sure about how valid they were. > > 0810:0003 Trust Predator > > actually seems to be a PlayStation Gamepad/Adapter according to the > USB ID Repository. [0] > Game-Debate [1] confirms this. > > 11c0:5506 BETOP GAMEFORWINDOWS > > is most likely BTP-2175 [2] which can also switch to DirectInput/HID mode (?) > where it aleady works out of the box with Linux [3] so this might possibly > break things. Or enable things as I'm not sure if the HID driver supports the rumble > functionality. > 360Controller detects it as Xbox 360 Controller on OS X [4] with this ID, so it might actually > be a good idea to add it back. I don't have strong feelings either way on this. We won't stop the HID stack from picking up this device if it exposes a standard HID interface (in one of its many modes). As an aside, it looks in [3] like it's being detected as an official Microsoft Xbox 360 pad (based on the device name). If that screenshot is legitimate, it means that the gamepad is doing some shady things, but also that we don't need to do anything special to support it. In any case, it definitely seems like it works out of the box with Fedora 25 and a Kindle Fire HD 8 running Android which lets us know _something_ in the kernel already supports it (maybe only in certain modes). > >> I also have a few name nits to throw in your respin. > > I will address those in v3 Thanks! > > [0] https://usb-ids.gowdy.us/read/UD/0810/0003 > [1] http://www.game-debate.com/gamepad/index.php?ga_id=41&gamepad=Trust%20Predator > [2] https://www.banggood.com/de/Betop-BTP-2175-Asura-Double-Vibration-Computer-Game-Controller-p-1063903.html > [3] http://unsolicitedbutoffered.blogspot.de/2017/04/tested-betop-controller-with-fedora-25.html > [4] http://unsolicitedbutoffered.blogspot.de/2017/05/tested-betop-controller-openemu_7.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
