On Wed, Apr 26, 2017 at 9:34 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > + * HID driver for ELECOM devices. > > * Copyright (c) 2010 Richard Nauber <Richard.Nauber@xxxxxxxxx> > > + * Copyright (c) 2016 Yuxuan Shui <yshuiv7@xxxxxxxxx> > > If new copyright of a 3rd party is being added, I'd like to see explicit > Signed-off-by: from that person. Yuxuan Shui is CCed to this thread so I hope he can sign off it. For what it's worth, the only thing I took from his patch is the ID of the ELECOM DEFT wired which I don't have and so wouldn't know (nor would I have known it needed the same descriptor hotfix). Please advise. > Missing break? Good catch, fixed. > > + * Report Count (1), | Report Count (0), > > I personally don't find the '|' notation for diff really straightforward > ... how about '->', so that it's clear which are the old and new values? Great idea, done :) This was the output of diff -y -- but since I had to change it anyway to make it fit into the comment, it makes sense to replace that too. Thanks! Diego -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
