Re: [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 25, 2017 at 06:27:04AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> 
> Fixes the following sparse warning:
> 
> drivers/input/touchscreen/mxs-lradc-ts.c:33:12: warning:
>  symbol 'mxs_lradc_ts_irq_names' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> index 4b4aebf..603ac5a 100644
> --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -30,7 +30,7 @@
>  #include <linux/of_irq.h>
>  #include <linux/platform_device.h>
>  
> -const char *mxs_lradc_ts_irq_names[] = {
> +static const char *mxs_lradc_ts_irq_names[] = {

FWIW checkpatch recommends "static const char * const".

>  	"mxs-lradc-touchscreen",
>  	"mxs-lradc-channel6",
>  	"mxs-lradc-channel7",
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux