Hi Wei, On Mon, Apr 24, 2017 at 11:26 PM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote: > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > In case of error, the function devm_ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. I'd rather we switched to devm_ioremap_resource() that does return ERR_PTR-encoded error. > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > drivers/input/touchscreen/mxs-lradc-ts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c > index 4b4aebf..ff9cda2 100644 > --- a/drivers/input/touchscreen/mxs-lradc-ts.c > +++ b/drivers/input/touchscreen/mxs-lradc-ts.c > @@ -631,8 +631,8 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev) > > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > ts->base = devm_ioremap(dev, iores->start, resource_size(iores)); > - if (IS_ERR(ts->base)) > - return PTR_ERR(ts->base); > + if (!ts->base) > + return -ENOMEM; > > ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires", > &ts_wires); > Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
