On Mon, Apr 24, 2017 at 9:42 AM, Jean Delvare <jdelvare@xxxxxxx> wrote:
> The tm2-touchkey driver is only useful on specific platforms. Add the
> missing hardware dependency so that the driver is not proposed on
> systems where the device does not exist.
Although the device exists in only two upstreamed Exynos boards but
there is no hardware dependency on Exynos. The hardware does not
depend on Exynos.
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Fixes: 72d1f2346ded ("Input: tm2-touchkey - add touchkey driver support for TM2")
I do not see a bug to fix. Even if we agree that driver building
should be limited to Exynos then definitely there is no missing
dependency to fix.
Best regards,
Krzysztof
> Cc: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
> Cc: Beomho Seo <beomho.seo@xxxxxxxxxxx>
> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> Cc: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> Note: I am not familar with the hardware in question so I'm not sure
> if this is the right dependency to add, or if ARM64 would be more
> appropriate, or something else, or a combination thereof. Please
> advise.
>
> drivers/input/keyboard/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-4.11-rc8.orig/drivers/input/keyboard/Kconfig 2017-04-03 02:23:54.000000000 +0200
> +++ linux-4.11-rc8/drivers/input/keyboard/Kconfig 2017-04-24 09:26:43.314252700 +0200
> @@ -670,6 +670,7 @@ config KEYBOARD_TM2_TOUCHKEY
> tristate "TM2 touchkey support"
> depends on I2C
> depends on LEDS_CLASS
> + depends on ARCH_EXYNOS || COMPILE_TEST
> help
> Say Y here to enable device driver for tm2-touchkey with
> LED control for the Exynos5433 TM2 board.
>
>
> --
> Jean Delvare
> SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
