On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas <tomas.winkler@xxxxxxxxx> wrote: >> New helpers take pointers to uuid_{be|le} as parameters. >> >> When using them on a raw data we don't need to do an ugly dereference and, >> in some cases, a type casting. > I think this going overboard, the _pp types are just enough. I looked at existing users and there are cases like #define XXX_UUID UUID_...(a, b, c, ...) uuid_.*_cmp(value, XXX_UUID) For _pp variant if would be _cmp_pp(value, &XXX_UUID) which is slightly worse than for _p variant. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html