Re: [PATCH v2.2] HID: hid-elecom: extend to fix the descriptor for DEFT trackballs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



First of, sorry for the extra noisy, spammy posting. Two of the
versions (v2 and v2.1) are actually the same because I have not used
`git send-email` in long enough I forgot how it works, shame on me!

On Fri, Apr 21, 2017 at 6:42 PM, Diego Elio Pettenò
<flameeyes@xxxxxxxxxxxx> wrote:
> The ELECOM DEFT trackballs report only five buttons, when the device
> actually has 8. Change the descriptor so that the HID driver can see all of
> them

Version 2.2 (which is the only other one aside from the original that
actually *does* compile) effectively merges Yuxuan Shui's
(https://patchwork.kernel.org/patch/9217713/) by including both the
wired and wireless DEFT IDs.

Unlike last year's patch, it does not create a new driver/module but
extends the already-present hid-elecom. This looks to me matching the
behaviour of other HID quirk drivers.

Also, to remove the extraneous 3 "constant" bits, it just nulls out
the count, rather than getting rid of the bytecode, which required a
memmove of the remaining structure, making it less invasive and
(hopefully) less prone to bugs.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux