[bug report] HID: wacom: Introduce new 'touch_input' device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jason Gerecke,

This is a semi-automatic email about new static checker warnings.

The patch 2a6cdbdd4cc0: "HID: wacom: Introduce new 'touch_input' 
device" from Jun 15, 2015, leads to the following Smatch complaint:

drivers/hid/wacom_wac.c:1586 wacom_tpc_irq()
	 error: we previously assumed 'wacom->touch_input' could be null (see line 1577)

drivers/hid/wacom_wac.c
  1576				"%s: received report #%d\n", __func__, data[0]);
  1577		else if (wacom->touch_input)
                         ^^^^^^^^^^^^^^^^^^
Patch adds new check for NULL.

  1578			dev_dbg(wacom->touch_input->dev.parent,
  1579				"%s: received report #%d\n", __func__, data[0]);
  1580	
  1581		switch (len) {
  1582		case WACOM_PKGLEN_TPC1FG:
  1583			return wacom_tpc_single_touch(wacom, len);
  1584	
  1585		case WACOM_PKGLEN_TPC2FG:
  1586			return wacom_tpc_mt_touch(wacom);
                                                  ^^^^^
Not checked inside this function call.

  1587	
  1588		case WACOM_PKGLEN_PENABLED:

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux