On 11/04/17 11:00, Oleksandr Andrushchenko wrote:
> Hi, Juergen,
>
> could you please make one more patch in the series:
>
> the code that you fix in this patch is ok, but most
>
> of the functionality of the xenkbd_set_connected
>
> is still useless: feature-abs-pointer/request-abs-pointer
>
> negotiation has only meaning at probe time, when we are
>
> configuring input device:
>
> if (abs) {
> __set_bit(EV_ABS, ptr->evbit);
> input_set_abs_params(ptr, ABS_X, 0, XENFB_WIDTH, 0, 0);
> input_set_abs_params(ptr, ABS_Y, 0, XENFB_HEIGHT, 0, 0);
> } else {
> input_set_capability(ptr, EV_REL, REL_X);
> input_set_capability(ptr, EV_REL, REL_Y);
> }
> Once the input device is configured and registered (probe done)
>
> we do not touch/re-configure that input device anymore,
>
> regardless of the setting negotiation at xenkbd_set_connected
>
> time. Thus, this code is not needed and can be cleaned out.
>
> What your patch actually fixes is the fact that
>
> "xenbus_switch_state(dev, XenbusStateConnected);" was not called,
>
> so this is the only line needed.
This makes sense.
I'll modify patch2 according to your suggestion instead of adding
another patch removing most of the stuff added by patch 2.
Juergen
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
