On Sun, Mar 26, 2017 at 01:41:08PM -0300, Marcos Paulo de Souza wrote: > Hi Jon, > > On Fri, Mar 24, 2017 at 03:17:03PM -0600, Jonathan Corbet wrote: > > On Fri, 24 Mar 2017 00:34:58 -0300 > > Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx> wrote: > > > > > this is the second iteration of this patch. The first version can be checked > > > here[1]. A special thanks to Peter Hutterer who dug the last patch and suggested > > > a lot of changes , hopefully, all addressed in this version. > > > > This seems like a good start. Of course, I have a couple of comments... > > > > 1) RST documentation is good, but it really needs to be hooked into the > > docs build with the rest. In this case, it needs to go into the > > application developer's manual. The only slight snag is ... well ... > > that manual doesn't quite exist yet. Once this is ready, if it comes > > through me tree, I can follow it with a patch creating that manual and > > moving this section into it. > > Sounds good. If you want, I can verify and add this new page as well. > > > > > 2) We don't normally put in section numbers manually in RST documents, > > since Sphinx will do that for us. > > Great, fixed here. > > > > > 3) Section 3.0 covers the old interface. I'm not sure we need that in > > documentation in current kernels which, by definition, have the > > current interface. > > Currently both interces can be used in mainline, but this can be nice to have for users > who still run older kernels. But I can remove if you strongly disagree. Given the kernel's policy for retiring interfaces, the old interface will be available forever. But at this point you shouldn't be writing new software against the old interface. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html