On Thu, Mar 9, 2017 at 11:55 AM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Thu, Mar 09, 2017 at 04:18:40PM +0100, Yegor Yefremov wrote: >> On Thu, Mar 9, 2017 at 3:49 PM, Rob Herring <robh@xxxxxxxxxx> wrote: >> > On Thu, Mar 9, 2017 at 8:31 AM, <yegorslists@xxxxxxxxxxxxxx> wrote: >> >> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> >> > >> > This needs to go to DT list. >> >> Will do. >> >> >> >> >> Provide description for following properties: >> >> >> >> - ti,poll-period >> >> - ti,min-pressure >> >> >> >> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> >> >> --- >> >> Documentation/devicetree/bindings/mfd/tps6507x.txt | 16 ++++++++++++++-- >> >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt b/Documentation/devicetree/bindings/mfd/tps6507x.txt >> >> index 8fffa3c..8875662 100644 >> >> --- a/Documentation/devicetree/bindings/mfd/tps6507x.txt >> >> +++ b/Documentation/devicetree/bindings/mfd/tps6507x.txt >> >> @@ -1,4 +1,8 @@ >> >> -TPS6507x Power Management Integrated Circuit >> >> +TPS6507x Multifunctional Device. >> >> + >> >> +Features provided by TPS6507x: >> >> + 1. Power Management Integrated Circuit. >> >> + 2. Touch-Screen. >> >> >> >> Required properties: >> >> - compatible: "ti,tps6507x" >> >> @@ -30,6 +34,12 @@ Regulator Optional properties: >> >> 1: If defdcdc pin of DCDC2/DCDC3 is driven HIGH. >> >> If this property is not defined, it defaults to 0 (not enabled). >> >> >> >> +Touchscreen Optional properties: >> >> +- ti,poll-period: Time at which touch input is getting sampled in ms. >> >> + Default value: 30 ms. >> > >> > Isn't there a standard property for this? >> >> Such a value will be already used in [1]. I've looked at [2], but it >> doesn't have such a field. >> >> [1] Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt >> [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt > > I think the bigger question (since we are adding this to DT I assume it > is not longer "toy" driver) can we convert it to a proper > interrupt-driven scheme? Polling for real shipping devices is not > efficient, I do not think we should even try to allow this mode in DTS > bindings (note that tsc2007 use is different: it allows to specify > sampling interval once touch is detected). I guess I was assuming that polling period corresponded to sampling period or rate. The latter makes more sense for a binding and I would think is fairly common whether the h/w has functionality or the driver has to implement the sampling rate in s/w. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
