Hi,
On 09-03-17 15:45, Hans de Goede wrote:
Hi,
On 09-03-17 15:03, Andy Shevchenko wrote:
On Thu, 2017-03-09 at 14:57 +0100, Hans de Goede wrote:
Hi,
On 08-03-17 19:25, Andy Shevchenko wrote:
<snip soc_button_array stuff>
I think that "extcon: int3496: Add GPIO ACPI mapping
table"
will
need
a similar change (I haven't tested it yet).
So I assume you want to do the same (pass NULL as con-id to
gpiod_get_index()) for the extcon-in3496 driver or do you want
to keep the GPIO ACPI mapping table there?
A slightly preferable table variant (needs to be fixed I guess)
because
initial one used to have different labels.
Ok, I will test with the acpi-mapping table then and if necessary
create a fixup patch for it and send that to you.
Sounds like a plan!
Since extcon patches are landed already mainstream it might make sense
to send it as usual to all maintainers.
Ack, so to be clear we should use gpiod_get not gpiod_get_index with
the acpi mapping table, right ? The reason I'm asking is that my
test devices only have the id pin which has index 0 so in my
experience with soc_button_array it will work with both
(the button with index 0 would even work with gpiod_get_index).
Ok, so there is one problem with the extcon-intel-int3496.c
together with your gpio patches:
[ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
[ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
[ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
[ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
[ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22
This can be fixed / worked around by doing this:
--- a/drivers/extcon/extcon-intel-int3496.c
+++ b/drivers/extcon/extcon-intel-int3496.c
@@ -113,6 +113,7 @@ static int int3496_probe(struct platform_device *pdev)
dev_err(dev, "can't request USB ID GPIO: %d\n", ret);
return ret;
}
+ gpiod_direction_input(data->gpio_usb_id);
data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id);
if (data->usb_id_irq < 0) {
But the gpio is requested as:
data->gpio_usb_id = devm_gpiod_get(dev, "id", GPIOD_IN);
Note the GPIOD_IN I think the new behavior is caused by:
https://bitbucket.org/andy-shev/linux/commits/ba458eb945879a66eac75de69a4e7312c4f44cc7
Of which I'm not sure it is a good idea, as the dsdt of my
cube iwork8 air shows:
Device (OTG2)
{
Name (_HID, "INT3496") // _HID: Hardware ID
Name (_CID, "INT3496") // _CID: Compatible ID
Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings
{
Name (ABUF, ResourceTemplate ()
{
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
"\\_SB.GPO1", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x0003
}
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
"\\_SB.GPO3", 0x00, ResourceConsumer, ,
)
{ // Pin list
0x002E
}
})
Return (ABUF) /* \_SB_.PCI0.OTG2._CRS.ABUF */
}
}
The dstd-s out there in the wild do not always get this right.
With my workaround from above the extcon-intel-int3496 driver
does work properly again, so I see 2 options here:
1) Let drivers workaround known broken IoRestriction in dstd-s
by using gpiod_direction_...
2) Drop the patch which makes gpiod_get honor the IoRestrictions
I've also tested the silead driver and with the new more strict
gpio code it works as it should as-is (as expected).
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
