> On Mon, Mar 6, 2017 at 9:09 AM, Michał Kępień <kernel@xxxxxxxxxx> wrote: > >> On Thu, Mar 2, 2017 at 2:02 PM, Michał Kępień <kernel@xxxxxxxxxx> wrote: > > >> > + * Since sparse_keymap_setup() now uses a managed allocation for the > >> > + * keymap copy, use of this function is deprecated. > >> > >> So... > >> > >> > */ > >> > void sparse_keymap_free(struct input_dev *dev) > >> > >> ... add __deprecated then? > > > > Sure, I can do that if Dmitry recognizes this patch as otherwise sane. > > I have never used that attribute before, so thanks for the tip. > > It will provoke a warning when compiling the code. > It makes sense if anyone is going to fix the current users and leave > old API for one cycle. > > So, the question is what we are going to do with an old API. If this is a latent call to clean it up, then sure, I can take care of it ;) A quick scan shows ca. 30 call sites in the entire tree, fixing which seems to be doable given a few weeks of time. Though obviously I would really like to hear that the patch looks sound before I set out on that journey. -- Best regards, Michał Kępień -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
