Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> This kind of change is definitely not helpful. The original table was
> Nx16, you converted it to Nx14. Why do you think original table used 16
> columns?
> 
> Regardless, it's a very old driver, just let it be.
> 
> Thanks.
> 

I can make it Nx8 :)

Seriously now - I don't understand what is so wrong with checkpatch fixes?
I'm a new to kernel development, and the natural place to start is to do some
coding style fixes.
I thought fixing a driver that I actually use daily will be more satisfying.
Why driver being old is a good reason to ignore the coding style conventions?

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux