Hello Dmitry, On 02/23/2017 05:31 AM, Dmitry Torokhov wrote: > On Tue, Feb 21, 2017 at 03:12:53PM -0300, Javier Martinez Canillas wrote: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device registered via OF will always match a legacy I2C device ID and >> that the MODALIAS reported will always be of the form i2c:<device>. >> >> But this could change in the future so the correct approach is to have an >> OF device ID table if the devices are registered via OF. > > This driver is for touchpad controller on a specific device, and as far > as I understand, for a specific firmware. I am not sure if it will ever > be reused. > > Igor, maybe we need to drop it altogether? > It's used in a mainline DTS (arch/arm/boot/dts/imx23-sansa.dts), that's why I included in the set. >> >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> --- >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html