Hi Bastien, Thank you for your comment. > -----Original Message----- > From: Bastien Nocera [mailto:hadess@xxxxxxxxxx] > Sent: Wednesday, February 15, 2017 2:28 AM > To: Ping Cheng <pinglinux@xxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx > Cc: jikos@xxxxxxxxxx; benjamin.tissoires@xxxxxxxxx; dmitry.torokhov@xxxxxxxxx; Cheng, Ping <Ping.Cheng@xxxxxxxxx>; Cheng, Ping <Ping.Cheng@xxxxxxxxx> > Subject: Re: [PATCH 3/3] HID: wacom: generic: support touch on/off softkey > > On Tue, 2017-02-14 at 21:27 -0800, Ping Cheng wrote: >> Wacom Cintiq Pro has a softkey to turn touch on/off. Since it is a >> softkey, hardware/firmware still reports touch events no matter what >> state the softkey is. We need to ignore touch events when the key is >> in off mode. > > Why can't this simply be reported to user-space to handle? This would allow an OSD popping up. Implementing everything in the driver means that we're setting ourselves up for "fat finger" bug reports where the user doesn't know that they disabled the tablet, as there would be no notification of the change. I see your point. But, the reasons to support your point don't match with the reality. 1. We still send an event (SW_MUTE_DEVICE) to inform user(land) that touch is disabled. So, if you plan to popup an OSD, you are well informed. Plus, there is a LED on the tablet to indicate its for touch on/off. Users should know what they are doing unless they accidentally touch it, which is, uh, an accident. 2. Allow kernel to take care of it is better than having clients repeat the same implementation everywhere. This is especially helpful for those applications that communicate with kernel directly. This patch is to make sure the key does what it meant to. Cheers. Ping -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
